Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced python_backend autocomplete #317

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Enhanced python_backend autocomplete #317

merged 2 commits into from
Nov 2, 2023

Conversation

oandreeva-nv
Copy link
Contributor

@oandreeva-nv oandreeva-nv commented Nov 1, 2023 •
edited
Loading

Added an ability to add optional input from autocomplete function + set model_transaction_policy
Note: pre-commit hook fails not on my code

@oandreeva-nv oandreeva-nv changed the title Added to python_backend autocomplete Enhanced python_backend autocomplete Nov 1, 2023
@oandreeva-nv oandreeva-nv mentioned this pull request Nov 1, 2023
Merged
@oandreeva-nv oandreeva-nv requested review from dyastremsky, krishung5, Tabrizian and rmccorm4 and removed request for dyastremsky November 1, 2023 23:32
dyastremsky
dyastremsky reviewed Nov 2, 2023
View reviewed changes
Copy link
Contributor

@dyastremsky dyastremsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work, Olga! Does this require any new documentation?

@oandreeva-nv
Copy link
Contributor Author

@dyastremsky Good question, I'll double check

@oandreeva-nv oandreeva-nv merged commit 0f12211 into main Nov 2, 2023
3 checks passed
@oandreeva-nv oandreeva-nv deleted the oandreeva_autocomplete branch November 2, 2023 21:46
@oandreeva-nv oandreeva-nv mentioned this pull request Nov 3, 2023
Merged
tanmayv25 pushed a commit that referenced this pull request Nov 8, 2023
@oandreeva-nv
Follow up to autocomplete pr #317 (#320)
60a9091 
* Fllow up with error msg

* Setting decoupled after autocomplete in ModelState:Create

* Refactor

* Refactor according to Tanmay discussion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyastremsky dyastremsky dyastremsky left review comments

@krishung5 krishung5 krishung5 approved these changes

@Tabrizian Tabrizian Awaiting requested review from Tabrizian

@rmccorm4 rmccorm4 Awaiting requested review from rmccorm4

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oandreeva-nv @krishung5 @dyastremsky